Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(esp32): Added a new device(xiao esp32s3 plus) #10768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(esp32): Added a new device(xiao esp32s3 plus) #10768

wants to merge 3 commits into from
+278 −0

Conversation

is-qian
Copy link

@is-qian is-qian commented Dec 21, 2024

Description of Change

feat(esp32): Added a new device from Seeed: Xiao ESP32S3 Plus

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello is-qian, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3e1c30c

@lucasssvaz lucasssvaz added Type: 3rd party Boards Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Dec 21, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y removed the Status: Pending CLA ⚠️ Contributor is required to sign the CLA label Jan 6, 2025
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jan 6, 2025
View reviewed changes
boards.txt Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response awaiting a response from the author label Jan 6, 2025
P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jan 17, 2025
View reviewed changes
boards.txt
XIAO_ESP32S3_PLUS.menu.PartitionScheme.max_app_8MB.upload.maximum_size=8257536
XIAO_ESP32S3_PLUS.menu.PartitionScheme.tinyuf2=TinyUF2 8MB (2MB APP/3.7MB FFAT)
XIAO_ESP32S3_PLUS.menu.PartitionScheme.tinyuf2.build.custom_bootloader=bootloader-tinyuf2
XIAO_ESP32S3_PLUS.menu.PartitionScheme.tinyuf2.build.custom_partitions=partitions-8MB-tinyuf2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The partition name does not match with the partition file name you added to the variant folder.
partitions-8MB-tinyuf2 vs partitions-8MB. Please fix the naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Status: Awaiting Response awaiting a response from the author Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@is-qian @CLAassistant @P-R-O-C-H-Y @lucasssvaz